Add exclude_attending to event search query#9164
Conversation
| if request.attending and request.exclude_attending: | ||
| context.abort_with_error_code( | ||
| grpc.StatusCode.INVALID_ARGUMENT, "cannot_combine_attending_and_exclude_attending" | ||
| ) |
There was a problem hiding this comment.
The other one had include_attending which was a bit different but I think it still doesn't make sense to allow both at the same time?
MobileInstall the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here. Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.
Deep linksiOS Android Web (Vercel)View the Vercel web preview for this branch. Backend
Other
|
| if where_: | ||
| statement = statement.where(or_(*where_)) | ||
|
|
There was a problem hiding this comment.
an empty OR means "no inclusion filter" (return everything), not "return nothing"?
github-actions
Bot
added
the
release notes: pending
📝 Release NotesThis PR should be included in the release notes. Suggested release note: 🤖 Bot Debug InformationModel: |
3 participants
I didn't realize when I did the other that this is a separate query (since this one supports more searching params). Adding it here too.
Testing
Explain how you tested this PR and give clear steps so the reviewer can replicate.
Backend checklist
developif necessary for linear migration historyFor maintainers